fix: gh pages sync #3857
Merged
fix: gh pages sync #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Closed
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
andrewb1269hg
previously approved these changes
Jun 16, 2025
Test Results 20 files - 1 256 suites - 25 18m 13s ⏱️ -3s Results for commit f08d44e. ± Comparison against base commit 8c7fbc9. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
andrewb1269hg
previously approved these changes
Jun 16, 2025
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
andrewb1269hg
approved these changes
Jun 16, 2025
nathanklick
approved these changes
Jun 17, 2025
mwb-al
pushed a commit
to mwb-al/hiero-json-rpc-relay
that referenced
this pull request
Jun 23, 2025
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request updates GitHub Actions workflows to enhance security and improve configuration consistency. Key changes include modifying permissions, adding GPG key import steps, and ensuring proper configuration for GPG signing.
Workflow Permissions and Security Enhancements:
.github/workflows/gh-pages-sync.yaml: Changedcontentspermission fromwritetoreadfor improved security.GPG Signing and Configuration Updates:
.github/workflows/gh-pages-sync.yaml: Added a step to import a GPG key for signing commits and tags, using thestep-security/ghaction-import-gpgaction. Configured the GPG signing process with environment variables and secrets for user details and passphrase..github/workflows/release-automation.yml: Updated the GPG signing step to includegit_committer_emailandgit_committer_namefor consistency with thegh-pages-syncworkflow.Related issue(s):
Fixes #3856
Testing: