Skip to content

chore: include eth_createAccessList as an unsupported method #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Jun 13, 2025

Description:

This PR adds RPC method eth_createAccessList as unsupported.

Related issue(s):

Fixes #3489.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica linked an issue Jun 13, 2025 that may be closed by this pull request
@acuarica acuarica self-assigned this Jun 13, 2025
@acuarica acuarica added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Jun 13, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jun 13, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@acuarica acuarica added this to the 0.70.0 milestone Jun 13, 2025
Copy link

github-actions bot commented Jun 13, 2025

Test Results

 20 files   -   1  256 suites   - 24   18m 10s ⏱️ -20s
665 tests ±  0  660 ✅ +  1  5 💤 ±0  0 ❌  - 1 
681 runs   - 114  676 ✅  - 113  5 💤 ±0  0 ❌  - 1 

Results for commit 100e6b5. ± Comparison against base commit 5ed656a.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
"after all" hook in "@web-socket-batch-2 eth_getLogs" ‑ RPC Server Acceptance Tests Acceptance tests @web-socket-batch-2 eth_getLogs "after all" hook in "@web-socket-batch-2 eth_getLogs"
should not support "eth_createAccessList" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests @release Unsupported RPC Endpoints should not support "eth_createAccessList"

♻️ This comment has been updated with latest results.

@acuarica acuarica marked this pull request as ready for review June 14, 2025 01:04
@acuarica acuarica requested review from a team as code owners June 14, 2025 01:04
@acuarica acuarica requested a review from konstantinabl June 14, 2025 01:04
natanasow
natanasow previously approved these changes Jun 16, 2025
Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simzzz simzzz self-requested a review June 16, 2025 13:09
simzzz
simzzz previously approved these changes Jun 16, 2025
Copy link
Contributor

@simzzz simzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica dismissed stale reviews from simzzz and natanasow via 100e6b5 June 16, 2025 13:39
@konstantinabl konstantinabl requested a review from simzzz June 16, 2025 15:35
Copy link
Contributor

@konstantinabl konstantinabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuarica acuarica merged commit 8c7fbc9 into main Jun 16, 2025
65 of 67 checks passed
@acuarica acuarica deleted the 3489-investigate-implementation-for-eth_createaccesslist branch June 16, 2025 17:44
mwb-al pushed a commit to mwb-al/hiero-json-rpc-relay that referenced this pull request Jun 23, 2025
…-ledger#3852)

Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate implementation for eth_createAccessList
6 participants