Skip to content

fix: enabled Jumbo Transaction testing #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

quiet-node
Copy link
Contributor

@quiet-node quiet-node commented Jun 6, 2025

Description:

This PR upgrades local-node to version 2.37.1, which supports Consensus Node @^0.62.2—the latest stable version with Jumbo Transaction support.

It also upgrades the overridden ethers.js to v6 to avoid conflicts with child dependencies introduced by local-node@2.37.0.

Related issue(s):

Fixes #3769

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added this to the 0.69.0 milestone Jun 6, 2025
@quiet-node quiet-node self-assigned this Jun 6, 2025
@quiet-node quiet-node requested review from a team as code owners June 6, 2025 19:58
@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Jun 6, 2025
@quiet-node quiet-node linked an issue Jun 6, 2025 that may be closed by this pull request
@quiet-node quiet-node requested a review from simzzz June 6, 2025 19:58
@lfdt-bot
Copy link

lfdt-bot commented Jun 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

github-actions bot commented Jun 6, 2025

Test Results

    4 files   -    16    533 suites  +277   1m 1s ⏱️ - 17m 5s
1 835 tests +1 169  1 834 ✅ +1 173  1 💤  - 4  0 ❌ ±0 
1 848 runs  +1 166  1 847 ✅ +1 170  1 💤  - 4  0 ❌ ±0 

Results for commit dba175f. ± Comparison against base commit 27bcc1c.

This pull request removes 666 and adds 1835 tests. Note that renamed tests count towards both.
"eth_call" for non-existing contract address returns 0x ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call "eth_call" for non-existing contract address returns 0x
001 Should call pureMultiply ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 001 Should call pureMultiply
001 Should call pureMultiply ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 001 Should call pureMultiply
002 Should call msgSender ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 002 Should call msgSender
002 Should call msgSender ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 002 Should call msgSender
003 Should call txOrigin ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 003 Should call txOrigin
003 Should call txOrigin ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 003 Should call txOrigin
004 Should call msgSig ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 004 Should call msgSig
004 Should call msgSig ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 004 Should call msgSig
005 Should call addressBalance ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 005 Should call addressBalance
…
"eth_blockNumber" return the latest block number on second try ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" return the latest block number on second try
"eth_blockNumber" should return the latest block number using cache ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" should return the latest block number using cache
"eth_blockNumber" should return the latest block number ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" should return the latest block number
"eth_blockNumber" should throw an error if no blocks are found after third try ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" should throw an error if no blocks are found after third try
"eth_blockNumber" should throw an error if no blocks are found ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" should throw an error if no blocks are found
Adds a revertReason field for receipts with errorMessage ‑ @ethGetTransactionReceipt eth_getTransactionReceipt tests Adds a revertReason field for receipts with errorMessage
BLOCK_HASH filter timeouts and throws the expected error ‑ @ethGetLogs using MirrorNode timeout BLOCK_HASH filter timeouts and throws the expected error
BLOCK_HASH filter ‑ @ethGetLogs using MirrorNode BLOCK_HASH filter
Can extract the account number out of an account pagination next link url ‑ MirrorNodeClient Can extract the account number out of an account pagination next link url
Can extract the evm address out of an account pagination next link url ‑ MirrorNodeClient Can extract the evm address out of an account pagination next link url
…
This pull request removes 5 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
011 Should fail when calling msgValue with more value than available balance ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 011 Should fail when calling msgValue with more value than available balance
011 Should fail when calling msgValue with more value than available balance ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 011 Should fail when calling msgValue with more value than available balance
@release should execute "eth_sendRawTransaction" with Jumbo Transaction ‑ RPC Server Acceptance Tests Acceptance tests @sendRawTransactionExtension Acceptance Tests Jumbo Transaction @release should execute "eth_sendRawTransaction" with Jumbo Transaction
from/to Addresses in transaction to a contract (deployed through HAPI tx) are in evm and long-zero format ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests Formats of addresses in Transaction and Receipt results from/to Addresses in transaction to a contract (deployed through HAPI tx) are in evm and long-zero format
should not return contract bytecode after sefldestruct ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode should not return contract bytecode after sefldestruct
supports optionality of request id when configured ‑ RPC Server given REQUEST_ID_IS_OPTIONAL=true are set supports optionality of request id when configured

♻️ This comment has been updated with latest results.

@quiet-node quiet-node marked this pull request as draft June 6, 2025 20:13
@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests branch 2 times, most recently from 7d9b0b9 to 021e8fc Compare June 12, 2025 15:37
@natanasow natanasow modified the milestones: 0.69.0, 0.70.0 Jun 13, 2025
@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests branch from bc409bc to 0dc7cb3 Compare June 13, 2025 17:30
@quiet-node
Copy link
Contributor Author

Closing due to known bugs #3769 (comment). Teams are working on resolving it so will re-visit the PR when things are more stable.

@quiet-node quiet-node closed this Jun 13, 2025
@quiet-node quiet-node reopened this Jun 18, 2025
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
- Upgraded local-node from version 2.32.5 to 2.37.1, which also involved upgrading @hashgraph/sdk from 2.49.2 to 2.66.0.
- The SDK upgrade introduced a large number of changes. With @hashgraph/sdk@2.66.0, the servicesNode.createHTS method used in batch3 failed with the following error:
StatusError: transaction transaction_id failed precheck with status INVALID_RENEWAL_PERIOD against node account id 0.0.3.
- To prevent test failures, reverted @hashgraph/sdk back to 2.49.2.
- A follow-up ticket will be created to resolve the SDK version discrepancy, as it is outside the scope of this PR.

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
- Upgraded local-node from version 2.32.5 to 2.37.1, which includes upgrading the Mirror Node from 0.118.0-rc1 to 0.131.0. This version gap introduces a large number of changes.
- The test “should NOT allow eth_call to process IHRC719.isAssociated()” is temporarily skipped and will be addressed in a follow-up PR.

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
This reverts commit 777c8df.
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests branch from 0dc7cb3 to dba175f Compare June 18, 2025 19:44
@quiet-node quiet-node closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Jumbo Transaction tests
3 participants