feat: stop skipping the confromity tests #3824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arianejasuwienas
changed the title
This was referenced Jun 5, 2025
Test Results 22 files + 2 315 suites +59 21m 36s ⏱️ + 3m 30s For more details on these failures, see this check. Results for commit e42da44. ± Comparison against base commit 27bcc1c. This pull request removes 421 and adds 421 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
This was referenced Jun 6, 2025
arianejasuwienas
force-pushed
the
3823-enable-previously-skipped-confirmity-tests
branch
from
261864f to
a3ca41a
Compare
quiet-node
reviewed
Jun 9, 2025
.../server/tests/acceptance/data/conformity/overwrites/eth_call/call-callenv-options-eip1559.io
Show resolved
Hide resolved
konstantinabl
requested changes
Jun 11, 2025
| currentBlockHash = await getLatestBlockHash(); | ||
| }); | ||
| //Reading the directories within the ethereum execution api repo | ||
| let directories = fs.readdirSync(directoryPath); | ||
| let directories = [...new Set([...fs.readdirSync(directoryPath), ...fs.readdirSync(overwritesDirectoryPath)])]; |
There was a problem hiding this comment.
Is this line needed if in overwrites we always have directories that are anyways existing in the original directorypath in the execution-apis repo?
There was a problem hiding this comment.
@konstantinabl It handles the case where there's an extra directory (containing a custom method not present in the OpenRPC API specification) in the overwrite directory that doesn't exist in the overwritten directory. It may not be necessary at this point, as it is not currently in use.
| await processFileContent(directory, file, content); | ||
| }); | ||
| } | ||
| const ls = (dir: string) => (fs.existsSync(dir) && fs.statSync(dir).isDirectory() ? fs.readdirSync(dir) : []); |
There was a problem hiding this comment.
I think we would benefit from some clarifications in the code here as well
quiet-node
previously approved these changes
Jun 13, 2025
konstantinabl
previously approved these changes
Jun 16, 2025
arianejasuwienas
dismissed stale reviews from konstantinabl and quiet-node
via
78f7674
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
arianejasuwienas
force-pushed
the
3823-enable-previously-skipped-confirmity-tests
branch
from
07cb39a to
e42da44
Compare
acuarica
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop skipping the tests - make it clear what tests are skipped and for what reason (#3823)
Description:
This task aims to stop skipping tests and clearly document which tests are being skipped and why. After merging this PR, it will be possible to run the full suite of tests. However, some test cases will be overridden to reflect Hedera-specific behavior until dedicated tasks are completed to properly implement their required presets.
Related issue(s):
Fixes #3823
Notes for reviewer:
Checklist