Skip to content

HV-2116 Do not recreate PersistenceUtil in the built-in JPATraversableResolver #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HV-2116

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.


Copy link

@gsmet
Copy link
Member

gsmet commented Jun 12, 2025

Did you discuss this with the Hibernate ORM team? Because I think it's a bit weird to create a new instance each time in Persistence?

And the fact that we missed this is a good example of why this can be misleading.

@gsmet
Copy link
Member

gsmet commented Jun 12, 2025

Note that it looks like something that should be merged and backported. I was just wondering if it could impact other projects out there.

@marko-bekhta
Copy link
Member Author

No, I was only looking into that other Quarkus issue related to the resolver and noticed this, so I pushed the change to be sure I wouldn't forget about it. Thanks for the suggestion, I'll start a topic on Zulip once I finish with the other HV "backport" 😃 🙈

@gsmet
Copy link
Member

gsmet commented Jun 12, 2025

Yeah, let's get it in though and backported because it allocates useless things in a relatively hot path.

@gsmet
Copy link
Member

gsmet commented Jun 12, 2025

Good catch :)

@marko-bekhta marko-bekhta merged commit 13807ee into hibernate:main Jun 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants