-
Notifications
You must be signed in to change notification settings - Fork 100
Migrate to Gradle version catalogs #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, I will have a look at this soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, looks great!
But I think something got lost in the changes.
When I run a test in the main branch, it prints:
> Configure project :
Project version: 4.0.0-SNAPSHOT (4.0)
Release version: n/a
Development version: n/a
ORM version: 7.0.2.Final
ORM Gradle plugin version: 7.0.2.Final
Vert.x SQL Client Version: 5.0.0
But after your changes, I see:
> Configure project :
Project version: 4.0.0-SNAPSHOT (4.0)
Release version: n/a
Development version: n/a
This information is quite because we tend to run Hibernate Reactive with different configurations.
Also, very nitpicky, but could you also add the issue number before the commit message? It makes my life easier when I need to track down changes.
I usually add it like this:
[#2331] Migrate to Gradle version catalogs
@sebersole Could you also have a look if this is what you had in mind when you created the issue? The approach looks good to me overall, but I don't have a lot of experience with catalogs.
Thanks a lot exoego!
I see.
If no override, it shows default versions defined in I initially thought it should be implemented near the place where version override is implemented. |
Roughly, yes. This does a bit more than I had anticipated doing, not sure yet whether they are good additions or not. I can take a deeper look if you want. I see you created an alternative PR... I'll look through that one. |
Closes #1989
Mostly auto-transformed by gradle-version-catalog-cli which I wrote.