Remove warnings #2116
Merged
Remove warnings #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
remove-warnings
branch
from
6a23f8a to
3d649a9
Compare
DavideD
force-pushed
the
remove-warnings
branch
from
3d649a9 to
00267dc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -232,15 +232,15 @@ | |||
| if ( s.indexOf( '/' ) != -1 ) { | |||
| // Example: 1234/ | |||
| s = s.substring( 0, s.indexOf( '/' ) ); | |||
| return Integer.valueOf( s ); | |||
| return Integer.parseInt( s ); | |||
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } | ||
| if ( s.indexOf( '?' ) != -1 ) { | ||
| // Example: 1234?param=value | ||
| s = s.substring( 0, s.indexOf( '?' ) ); | ||
| return Integer.valueOf( s ); | ||
| return Integer.parseInt( s ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } | ||
| // Example: 1234 | ||
| return Integer.valueOf( s ); | ||
| return Integer.parseInt( s ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| @@ -330,7 +330,7 @@ | |||
| if ( startOfPort == -1 ) { | |||
| return -1; | |||
| } | |||
| return Integer.valueOf( hostPortString.substring( startOfPort + 1 ) ); | |||
| return Integer.parseInt( hostPortString.substring( startOfPort + 1 ) ); | |||
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
gavinking
reviewed
Feb 13, 2025
...hibernate/reactive/provider/service/AbstractReactiveInformationSchemaBasedExtractorImpl.java
Outdated
Show resolved
Hide resolved
A mischellaneous collection of fixes for warnings that I've noticed working on this issue.
DavideD
force-pushed
the
remove-warnings
branch
from
00267dc to
ad16df0
Compare
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a miscellaneous list of warnings from IDEA.
I'm not sure it's worth it to have an issue for this