Fix double sign in method UI when using email #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing /auth again after the Account Chooser redirect cause ?mode=select to be stripped off the URL, resulting in the sign in method UI/dialog to be presented again instead of the password UI/dialog. Sign-in would still work if 'Sign in with email' was clicked again, but this commit corrects the behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing /auth again after the Account Chooser redirect caused
?mode=select to be stripped off the URL, resulting in the sign in method
UI/dialog to be presented again instead of the password UI/dialog.
Sign-in would still work if 'Sign in with email' was clicked again, but
this PR corrects the behaviour.