Add 35-mapping-modifiers #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondiano
reviewed
May 7, 2024
|
|
||
| Чтобы добавить или удалить эти модификаторы, можно использовать префиксы `+` или `-`. Если не использовать префикс, то подразумевается что модификатор будет добавлен, то есть по умолчанию префикс `+`. | ||
|
|
||
| Примеры использования модификаторов есть в Utility Types: |
There was a problem hiding this comment.
Давай подумаем над примером из реальной жизни
bondiano
reviewed
May 7, 2024
| Подобным образом можно написать и тип, который делает все свойства типа изменяемыми, то есть удаляет атрибут `readonly`: | ||
|
|
||
| ```typescript | ||
| type Mutable<T> = { |
There was a problem hiding this comment.
давай также покажем как используется
bondiano
reviewed
May 7, 2024
| -readonly [P in keyof T]: T[P]; | ||
| }; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
нужно добавить небольшой "рекап" - что мы изучили и как оно нам может пригодиться
bondiano
reviewed
May 7, 2024
| const deepFreeze = <T extends object>(obj: T): DeepReadonly<T> => { | ||
| Object.freeze(obj); | ||
|
|
||
| Object.values(obj).forEach((value) => { |
There was a problem hiding this comment.
мы стараемся писать имутабельный код
bondiano
reviewed
May 7, 2024
| @@ -0,0 +1,19 @@ | |||
| // BEGIN | |||
| type DeepReadonly<T> = { | |||
| readonly [P in keyof T]: T[P] extends object ? DeepReadonly<T[P]> : T[P]; | |||
There was a problem hiding this comment.
а что делать с массивами?
bondiano
reviewed
May 7, 2024
| @@ -0,0 +1,14 @@ | |||
|
|
|||
bondiano
reviewed
May 7, 2024
| }, | ||
| }; | ||
|
|
||
| expect(deepFreeze(obj)).toEqual({ |
There was a problem hiding this comment.
хорошо бы проверить что также сама логика валидная и мы не можем поменять свойства
someden
force-pushed
the
add-35-mapping-modifiers
branch
from
3058301 to
b4e8abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.