update request to extend headers passed #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekozilforce
force-pushed
the
ekozil/extend-not-overwrite-request-headers
branch
from
3fe75e1 to
9c0f67b
Compare
mble-sfdc
approved these changes
Jun 9, 2025
ekozilforce
added a commit
that referenced
this pull request
Jun 9, 2025
* update request to extend headers passed * yarn format:write
ekozilforce
added a commit
that referenced
this pull request
Jun 9, 2025
* update request to extend headers passed * yarn format:write
ekozilforce
added a commit
that referenced
this pull request
Jun 9, 2025
* update request to extend headers passed * yarn format:write
ekozilforce
added a commit
that referenced
this pull request
Jun 9, 2025
* update request to extend headers passed (#40) * update request to extend headers passed * yarn format:write * update changelog * fix inconsistent capitalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr updates docs for
HttpRequestUtil.requestand proposes a change to how we handle merging fetch options: we currently overwrite all headers and should consider extending them instead.Additionally, we add test coverage to
HttpRequestUtilto help catch issues earlier. See: https://salesforce-internal.slack.com/archives/C06EA6CPVST/p1749222091948929?thread_ts=1749211655.207919&cid=C06EA6CPVSTTesting
Added ci test for the new header logic