-
Notifications
You must be signed in to change notification settings - Fork 0
fix tests that are failing on github ci #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging in and finding a path forward. Tricky!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like CI checks are requiring a CHANGELOG update?
@dhagberg-sf I think we are okay to merge despite not updating the changelog here. Prob not worth tracking this on a changelog as nothing here impacts customers and its still ea. The changelog check was a pre-existing feature and we may need to refine it post-ga along with our rollout approach. |
This PR addresses the Java Heap memory issue that was causing certain environments, macos and later ubuntu to fail github ci/cd test. Specifically the large data ingest tests would fail because the size of the payload was exceeding the default memory size limitation. Along with an increase in default heap memory allocation to allow the largest bulk job to be successful we are clearing the wiremock results between each bulk test.