Skip to content

use native fetch, throw for non-2xxs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

ekozilforce
Copy link
Collaborator

@ekozilforce ekozilforce commented Jun 4, 2025

Description

This pr updates the sdk to use the native fetch module in node instead of node-fetch.

Additionally, this pr updates the SDK to throw when a fetch response is non-2xx.

See: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002EWjTJYA1/view

Testing

Automated tests should cover this change.

@ekozilforce ekozilforce marked this pull request as ready for review June 4, 2025 19:06
@ekozilforce ekozilforce requested a review from a team as a code owner June 4, 2025 19:06
@ekozilforce ekozilforce marked this pull request as draft June 4, 2025 19:07
@ekozilforce ekozilforce marked this pull request as ready for review June 5, 2025 11:18
@ekozilforce ekozilforce merged commit d794268 into main Jun 5, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants