-
Notifications
You must be signed in to change notification settings - Fork 0
Add coverage testing #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bdda439
to
5dd6541
Compare
Needs a |
b01c52d
to
b99b349
Compare
README.md
Outdated
|
||
### Running tests | ||
To test with coverage run `yarn coverage` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn test:coverage
f7d4a5c
to
c319ae7
Compare
07f01d8
to
ca7b5e2
Compare
.github/workflows/build.yml
Outdated
if: runner.os != 'macOS' | ||
|
||
- run: yarn test:coverage | ||
if: runner.os == 'macOS' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If macos isn't working due to the java heap running out of memory and we don't have a path to fix, we could remove it from the os matrix temporarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great improvement and this should close out multiple items on DoD.
I want to get this merged so we can get faster feedback as we make code changes, but we should circle back and get macos running in our test matrix before GA ideally.
You can run testing with
yarn coverage