Skip to content

onboard to component inventory #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

brahyt-sf
Copy link
Contributor

This pr seeks to onboard heroku-applink-nodejs to component library

Using this schema

@@ -0,0 +1,32 @@
{
"slug": "heroku-applink-nodejs",
"name": "Salesforce SDK for nodejs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applink SDK for Node.js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in npm it was called that. was unsure what this should be

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah nice catch. We will want to use a different npm repository name for GA. Going forward, let's use "Applink" instead of "Salesforce SDF".

We can make changes here and resync as needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool Ill change this up here

"sox": false,
"soc2": false,
"customer_facing": true,
"pager_duty_service_code": null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to leave this null for now, we will fill this in as part of https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002DOOR0YAP/view

@ekozilforce
Copy link
Collaborator

Approved assuming we remove the ref to "Salesforce SDK"

@brahyt-sf brahyt-sf force-pushed the components-inventory-onboarding branch from dd49c2c to c5ac677 Compare April 25, 2025 21:02
@brahyt-sf brahyt-sf closed this May 12, 2025
@brahyt-sf
Copy link
Contributor Author

This was closed. Repo should be public pending OSS review. Created pr in public component inventory https://github.com/heroku/components-public-repos/pull/57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants