-
Notifications
You must be signed in to change notification settings - Fork 0
onboard to component inventory #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,32 @@ | |||
{ | |||
"slug": "heroku-applink-nodejs", | |||
"name": "Salesforce SDK for nodejs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applink SDK for Node.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed in npm it was called that. was unsure what this should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah nice catch. We will want to use a different npm repository name for GA. Going forward, let's use "Applink" instead of "Salesforce SDF".
We can make changes here and resync as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool Ill change this up here
"sox": false, | ||
"soc2": false, | ||
"customer_facing": true, | ||
"pager_duty_service_code": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay to leave this null for now, we will fill this in as part of https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002DOOR0YAP/view
Approved assuming we remove the ref to "Salesforce SDK" |
dd49c2c
to
c5ac677
Compare
This was closed. Repo should be public pending OSS review. Created pr in public component inventory https://github.com/heroku/components-public-repos/pull/57 |
This pr seeks to onboard heroku-applink-nodejs to component library
Using this schema