Skip to content

Rename things to Applink #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Rename things to Applink #11

merged 1 commit into from
Apr 23, 2025

Conversation

gsinghsfdc
Copy link
Contributor

@gsinghsfdc gsinghsfdc requested a review from cwallsfdc April 21, 2025 17:47
@gsinghsfdc
Copy link
Contributor Author

CI is going to fail because things running on public workers but repo not being public

Copy link
Collaborator

@cwallsfdc cwallsfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Let's wait for a response in https://salesforce-internal.slack.com/archives/C06EA6CPVST/p1745429866865399.

logger.info(`Getting org '${orgName}' connection from Heroku Integration add-on...`);
const anotherOrg = await herokuIntegrationAddon.getConnection(orgName);
logger.info(`Getting org '${orgName}' connection from Heroku Applink add-on...`);
const anotherOrg = await applinkAddon.getConnection(orgName);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be getAuthorization(orgName[, addonName]). Likely change later, yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwallsfdc yep that will be a separate PR. Wanted to keep this scoped to just renaming

@gsinghsfdc gsinghsfdc merged commit 3220984 into main Apr 23, 2025
0 of 16 checks passed
@gsinghsfdc gsinghsfdc deleted the applink-rename branch April 23, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants