Skip to content

Conversation

@edmorley
Copy link
Member

(I'm opening a manual PR for this, since the GHA workflow doesn't support updating to releases still listed as pre-release)

Release notes:
https://github.com/buildpacks/lifecycle/releases/tag/v0.20.13

Full changelog:
buildpacks/lifecycle@v0.20.12...v0.20.13

Also corrects the lifecycle version listed in README for heroku/builder:20, which is no longer updated.

GUS-W-19336168.

Release notes:
https://github.com/buildpacks/lifecycle/releases/tag/v0.20.13

Full changelog:
buildpacks/lifecycle@v0.20.12...v0.20.13

Also corrects the lifecycle version listed in README for
`heroku/builder:20`, which is no longer updated.

GUS-W-19336168.
@edmorley edmorley self-assigned this Aug 14, 2025
@edmorley edmorley requested a review from a team as a code owner August 14, 2025 14:32
@edmorley
Copy link
Member Author

edmorley commented Aug 14, 2025

After this is released, language owners will need to update their libcnb-test integration test assertions to account for buildpack output now all going to stdout, per:
buildpacks/lifecycle#1525

@edmorley edmorley merged commit 205dee7 into main Aug 14, 2025
32 checks passed
@edmorley edmorley deleted the edmorley/update-lifecycle branch August 14, 2025 14:36
edmorley added a commit to heroku/buildpacks-php that referenced this pull request Aug 15, 2025
Due to:
heroku/cnb-builder-images#784 (comment)

Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
schneems added a commit to heroku/buildpacks-ruby that referenced this pull request Aug 15, 2025
CNB builder images v0.20.13 (heroku/cnb-builder-images#784) includes the fix for the interleaved buildpack stdout/stderr (buildpacks/lifecycle#1525), however, that will mean some CNB integration tests that test context.pack_stdout and context.pack_stderr will need updating.

The fix is to use stdout instead of stderr as lifecycle is now redirecting the output.
schneems added a commit to heroku/buildpacks-ruby that referenced this pull request Aug 15, 2025
* Fix clippy for Rust 1.89

```
 error: item in documentation is missing backticks
 --> commons/src/layer/fixtures/metadata_migration_example.md:1:11
  |
1 |  ## Setup DiffMigrateLayer for new layer Metadata
  |           ^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
  = note: `-D clippy::doc-markdown` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::doc_markdown)]`
help: try
  |
1 -  ## Setup DiffMigrateLayer for new layer Metadata
1 +  ## Setup `DiffMigrateLayer` for new layer Metadata
  |

    Checking libcnb-test v0.29.0
error: item in documentation is missing backticks
   --> commons/src/layer/fixtures/metadata_migration_example.md:108:13
    |
108 |   - Takes a bullet_stream printer for maximal printing consistency
    |             ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
    |
108 -   - Takes a bullet_stream printer for maximal printing consistency
108 +   - Takes a `bullet_stream` printer for maximal printing consistency
    |

error: could not compile `commons` (lib) due to 2 previous errors
```

```
warning: infallible TryFrom impl; consider implementing From, instead
   --> buildpacks/ruby/src/layers/bundle_install_layer.rs:145:1
    |
145 | impl TryFrom<MetadataV3> for MetadataV4 {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
146 |     type Error = std::convert::Infallible;
    |                  ------------------------ infallible error type
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_try_from
    = note: `#[warn(clippy::infallible_try_from)]` on by default
```

Close #448

* Fix integration tests to read stdout

CNB builder images v0.20.13 (heroku/cnb-builder-images#784) includes the fix for the interleaved buildpack stdout/stderr (buildpacks/lifecycle#1525), however, that will mean some CNB integration tests that test context.pack_stdout and context.pack_stderr will need updating.

The fix is to use stdout instead of stderr as lifecycle is now redirecting the output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants