Align minimum rust version to 1.86 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue was mentioned in heroku/buildpacks-deb-packages#110 (comment). This code was added in https://github.com/heroku-buildpacks/bullet_stream/pull/43/files and uses a feature of Rust 1.86 https://www.reddit.com/r/rust/comments/1ip51qt/trait_upcasting_stabilized_in_186/ (rust-lang/rust#134367). This usage wasn't realized at the time. No lints or tooling caught it. That Any upcast is critical for the feature introduced in #43. The easiest path forward is to align the MSRV with the reality of the current code. Semver version bump guidance from this thread to make this a minor change: https://users.rust-lang.org/t/rust-version-requirement-change-as-semver-breaking-or-not/20980/2.
schneems
force-pushed
the
schneems/fix-syntax
branch
from
16e3646 to
2a29479
Compare
```
error: variables can be used directly in the `format!` string
--> src/global.rs:678:9
|
678 | assert!(result.is_err(), "Expected panic to be caught {:?}", result);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
678 - assert!(result.is_err(), "Expected panic to be caught {:?}", result);
678 + assert!(result.is_err(), "Expected panic to be caught {result:?}");
|
error: could not compile `bullet_stream` (lib test) due to 1 previous error
```
schneems
added a commit
to heroku/buildpacks-deb-packages
that referenced
this pull request
Jul 1, 2025
More details in this PR to bullet_stream heroku-buildpacks/bullet_stream#47. And this comment reporting the issue #110 (comment). The short version is: This buildpack uses a dependency that accidentally uses a feature stabilized in Rust 1.86, but it didn't correctly update the minimum required Rust version. If it had, when #115 was merged, it would have also triggered the change that's now being made (I'm guessing this field is not linted, but I've not verified). This change corrects the problem by correctly stating the minimum Rust version so all dependencies can compile correctly.
edmorley
approved these changes
Jul 1, 2025
schneems
added a commit
to heroku/buildpacks-deb-packages
that referenced
this pull request
Jul 1, 2025
* Update Rust minimum version to 1.86 More details in this PR to bullet_stream heroku-buildpacks/bullet_stream#47. And this comment reporting the issue #110 (comment). The short version is: This buildpack uses a dependency that accidentally uses a feature stabilized in Rust 1.86, but it didn't correctly update the minimum required Rust version. If it had, when #115 was merged, it would have also triggered the change that's now being made (I'm guessing this field is not linted, but I've not verified). This change corrects the problem by correctly stating the minimum Rust version so all dependencies can compile correctly. * Update CHANGELOG.md Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com> Signed-off-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com> --------- Signed-off-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com> Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was mentioned in heroku/buildpacks-deb-packages#110 (comment). This code was added in https://github.com/heroku-buildpacks/bullet_stream/pull/43/files and uses a feature of Rust 1.86 https://www.reddit.com/r/rust/comments/1ip51qt/trait_upcasting_stabilized_in_186/ (rust-lang/rust#134367).
This usage wasn't realized at the time. No lints or tooling caught it. That Any upcast is critical for the feature introduced in #43. The easiest path forward is to align the MSRV with the reality of the current code.
Semver version bump guidance from this thread to make this a minor change: https://users.rust-lang.org/t/rust-version-requirement-change-as-semver-breaking-or-not/20980/2.
GUS-W-18939940