Skip to content

refactor(mm): remove physicalmem/virtualmem freestanding functions #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 24, 2025

Conversation

mkroening
Copy link
Member

No description provided.

@mkroening mkroening self-assigned this Jul 9, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark Current: faa1692 Previous: dc34ec0 Performance Ratio
startup_benchmark Build Time 101.45 s 81.04 s 1.25
startup_benchmark File Size 0.88 MB 0.88 MB 1.00
Startup Time - 1 core 0.90 s (±0.03 s) 0.84 s (±0.02 s) 1.07
Startup Time - 2 cores 0.91 s (±0.02 s) 0.85 s (±0.02 s) 1.07
Startup Time - 4 cores 0.89 s (±0.02 s) 0.86 s (±0.02 s) 1.03
multithreaded_benchmark Build Time 102.06 s 81.09 s 1.26
multithreaded_benchmark File Size 0.98 MB 0.99 MB 0.99
Multithreaded Pi Efficiency - 2 Threads 73.52 % (±4.65 %) 87.84 % (±7.18 %) 0.84
Multithreaded Pi Efficiency - 4 Threads 42.71 % (±2.82 %) 43.99 % (±3.13 %) 0.97
Multithreaded Pi Efficiency - 8 Threads 20.90 % (±1.16 %) 25.07 % (±1.59 %) 0.83
micro_benchmarks Build Time 83.27 s 95.35 s 0.87
micro_benchmarks File Size 0.99 MB 0.99 MB 0.99
Scheduling time - 1 thread 57.82 ticks (±2.19 ticks) 66.20 ticks (±2.82 ticks) 0.87
Scheduling time - 2 threads 34.44 ticks (±5.55 ticks) 37.16 ticks (±4.64 ticks) 0.93
Micro - Time for syscall (getpid) 14.45 ticks (±1.63 ticks) 15.40 ticks (±1.08 ticks) 0.94
Memcpy speed - (built_in) block size 4096 85187.46 MByte/s (±58820.01 MByte/s) 75907.21 MByte/s (±52469.23 MByte/s) 1.12
Memcpy speed - (built_in) block size 1048576 43500.69 MByte/s (±30086.96 MByte/s) 41624.91 MByte/s (±28898.76 MByte/s) 1.05
Memcpy speed - (built_in) block size 16777216 29465.10 MByte/s (±24238.05 MByte/s) 27960.73 MByte/s (±22980.50 MByte/s) 1.05
Memset speed - (built_in) block size 4096 84881.98 MByte/s (±58609.72 MByte/s) 75966.33 MByte/s (±52510.64 MByte/s) 1.12
Memset speed - (built_in) block size 1048576 43718.81 MByte/s (±30234.84 MByte/s) 41899.94 MByte/s (±29089.92 MByte/s) 1.04
Memset speed - (built_in) block size 16777216 30238.83 MByte/s (±24687.33 MByte/s) 28645.76 MByte/s (±23362.67 MByte/s) 1.06
Memcpy speed - (rust) block size 4096 73416.53 MByte/s (±51373.21 MByte/s) 65195.59 MByte/s (±45268.82 MByte/s) 1.13
Memcpy speed - (rust) block size 1048576 43206.46 MByte/s (±29901.64 MByte/s) 41257.95 MByte/s (±28657.44 MByte/s) 1.05
Memcpy speed - (rust) block size 16777216 29476.49 MByte/s (±24246.65 MByte/s) 27722.12 MByte/s (±22762.72 MByte/s) 1.06
Memset speed - (rust) block size 4096 73952.00 MByte/s (±51683.22 MByte/s) 65485.86 MByte/s (±45454.72 MByte/s) 1.13
Memset speed - (rust) block size 1048576 43461.15 MByte/s (±30074.63 MByte/s) 41487.88 MByte/s (±28816.91 MByte/s) 1.05
Memset speed - (rust) block size 16777216 30247.05 MByte/s (±24692.23 MByte/s) 28406.45 MByte/s (±23150.29 MByte/s) 1.06
alloc_benchmarks Build Time 82.32 s 93.14 s 0.88
alloc_benchmarks File Size 0.95 MB 0.95 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 69.96 % (±0.28 %) 69.96 % (±0.28 %) 1.00
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 9766.57 Ticks (±219.81 Ticks) 10295.19 Ticks (±294.34 Ticks) 0.95
Allocations - Average Allocation time (no fail) 9766.57 Ticks (±219.81 Ticks) 10295.19 Ticks (±294.34 Ticks) 0.95
Allocations - Average Deallocation time 663.65 Ticks (±7.11 Ticks) 701.09 Ticks (±14.78 Ticks) 0.95
mutex_benchmark Build Time 82.36 s 92.68 s 0.89
mutex_benchmark File Size 0.99 MB 0.99 MB 0.99
Mutex Stress Test Average Time per Iteration - 1 Threads 11.88 ns (±0.43 ns) 13.92 ns (±0.66 ns) 0.85
Mutex Stress Test Average Time per Iteration - 2 Threads 13.44 ns (±0.80 ns) 16.58 ns (±1.81 ns) 0.81

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening force-pushed the phys_virt_mem branch 6 times, most recently from 8c0c5f6 to 032aecf Compare July 10, 2025 09:35
@mkroening mkroening force-pushed the phys_virt_mem branch 3 times, most recently from 87b498d to a2fe8a0 Compare July 21, 2025 15:09
@mkroening mkroening marked this pull request as ready for review July 23, 2025 11:37
@mkroening mkroening added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 3ee9ca5 Jul 24, 2025
15 checks passed
@mkroening mkroening deleted the phys_virt_mem branch July 24, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants