-
Notifications
You must be signed in to change notification settings - Fork 104
refactor(drivers): Make virtio-net optional and feature-gated #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gelbpunkt
wants to merge
2
commits into
hermit-os:main
Choose a base branch
from
Gelbpunkt:virtio-net-optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+773
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06dc8b1
to
6b79416
Compare
cbd8ceb
to
bbee3cb
Compare
Gelbpunkt
added a commit
to Gelbpunkt/hermit-rs
that referenced
this pull request
Jul 15, 2025
hermit-os/kernel#1825 makes virtio-net an optional feature, enable it where necessary. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Gelbpunkt
added a commit
to Gelbpunkt/hermit-rs
that referenced
this pull request
Jul 15, 2025
hermit-os/kernel#1825 makes virtio-net an optional feature, enable it where necessary. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
ac7cad9
to
3810935
Compare
Gelbpunkt
added a commit
to Gelbpunkt/hermit-rs
that referenced
this pull request
Jul 15, 2025
hermit-os/kernel#1825 makes virtio-net an optional feature, enable it where necessary. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
3810935
to
57fcbf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark Results
Benchmark | Current: bbb7129 | Previous: 4a84d25 | Performance Ratio |
---|---|---|---|
startup_benchmark Build Time | 83.77 s |
87.39 s |
0.96 |
startup_benchmark File Size | 0.88 MB |
0.88 MB |
1.00 |
Startup Time - 1 core | 0.88 s (±0.02 s) |
0.93 s (±0.02 s) |
0.95 |
Startup Time - 2 cores | 0.88 s (±0.02 s) |
0.93 s (±0.01 s) |
0.94 |
Startup Time - 4 cores | 0.89 s (±0.02 s) |
0.93 s (±0.01 s) |
0.95 |
multithreaded_benchmark Build Time | 83.71 s |
86.04 s |
0.97 |
multithreaded_benchmark File Size | 0.98 MB |
0.98 MB |
1.00 |
Multithreaded Pi Efficiency - 2 Threads | 89.13 % (±8.99 %) |
88.29 % (±8.59 %) |
1.01 |
Multithreaded Pi Efficiency - 4 Threads | 43.98 % (±3.33 %) |
44.10 % (±3.40 %) |
1.00 |
Multithreaded Pi Efficiency - 8 Threads | 25.58 % (±1.90 %) |
25.37 % (±1.74 %) |
1.01 |
micro_benchmarks Build Time | 104.48 s |
85.38 s |
1.22 |
micro_benchmarks File Size | 0.98 MB |
0.98 MB |
1.00 |
Scheduling time - 1 thread | 62.78 ticks (±3.44 ticks) |
59.70 ticks (±2.64 ticks) |
1.05 |
Scheduling time - 2 threads | 34.03 ticks (±3.96 ticks) |
35.16 ticks (±4.53 ticks) |
0.97 |
Micro - Time for syscall (getpid) | 14.30 ticks (±0.94 ticks) |
14.31 ticks (±1.67 ticks) |
1.00 |
Memcpy speed - (built_in) block size 4096 | 78718.38 MByte/s (±54523.73 MByte/s) |
83116.66 MByte/s (±57474.29 MByte/s) |
0.95 |
Memcpy speed - (built_in) block size 1048576 | 43246.28 MByte/s (±29954.52 MByte/s) |
43185.37 MByte/s (±29862.04 MByte/s) |
1.00 |
Memcpy speed - (built_in) block size 16777216 | 28486.30 MByte/s (±23481.17 MByte/s) |
29129.50 MByte/s (±23947.84 MByte/s) |
0.98 |
Memset speed - (built_in) block size 4096 | 78989.53 MByte/s (±54716.89 MByte/s) |
83351.99 MByte/s (±57637.36 MByte/s) |
0.95 |
Memset speed - (built_in) block size 1048576 | 43483.37 MByte/s (±30109.95 MByte/s) |
43401.64 MByte/s (±30010.43 MByte/s) |
1.00 |
Memset speed - (built_in) block size 16777216 | 29236.59 MByte/s (±23916.55 MByte/s) |
29891.52 MByte/s (±24393.18 MByte/s) |
0.98 |
Memcpy speed - (rust) block size 4096 | 69494.07 MByte/s (±48411.81 MByte/s) |
72228.32 MByte/s (±50333.11 MByte/s) |
0.96 |
Memcpy speed - (rust) block size 1048576 | 43188.49 MByte/s (±29885.16 MByte/s) |
42874.06 MByte/s (±29664.74 MByte/s) |
1.01 |
Memcpy speed - (rust) block size 16777216 | 28439.41 MByte/s (±23421.95 MByte/s) |
29267.80 MByte/s (±24080.22 MByte/s) |
0.97 |
Memset speed - (rust) block size 4096 | 69916.90 MByte/s (±48737.20 MByte/s) |
72617.93 MByte/s (±50623.99 MByte/s) |
0.96 |
Memset speed - (rust) block size 1048576 | 43406.66 MByte/s (±30032.98 MByte/s) |
43100.09 MByte/s (±29821.73 MByte/s) |
1.01 |
Memset speed - (rust) block size 16777216 | 29153.77 MByte/s (±23826.79 MByte/s) |
30032.03 MByte/s (±24522.76 MByte/s) |
0.97 |
alloc_benchmarks Build Time | 100.71 s |
83.17 s |
1.21 |
alloc_benchmarks File Size | 0.94 MB |
0.94 MB |
1.00 |
Allocations - Allocation success | 100.00 % |
100.00 % |
1 |
Allocations - Deallocation success | 69.99 % (±0.24 %) |
69.97 % (±0.24 %) |
1.00 |
Allocations - Pre-fail Allocations | 100.00 % |
100.00 % |
1 |
Allocations - Average Allocation time | 9756.43 Ticks (±263.46 Ticks) |
10122.44 Ticks (±753.43 Ticks) |
0.96 |
Allocations - Average Allocation time (no fail) | 9756.43 Ticks (±263.46 Ticks) |
10122.44 Ticks (±753.43 Ticks) |
0.96 |
Allocations - Average Deallocation time | 677.14 Ticks (±16.66 Ticks) |
670.17 Ticks (±33.53 Ticks) |
1.01 |
mutex_benchmark Build Time | 101.64 s |
84.34 s |
1.21 |
mutex_benchmark File Size | 0.98 MB |
0.98 MB |
1.00 |
Mutex Stress Test Average Time per Iteration - 1 Threads | 13.06 ns (±0.54 ns) |
12.00 ns (±0.49 ns) |
1.09 |
Mutex Stress Test Average Time per Iteration - 2 Threads | 16.04 ns (±0.75 ns) |
13.44 ns (±1.10 ns) |
1.19 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
57fcbf2
to
bbb7129
Compare
Gelbpunkt
added a commit
to Gelbpunkt/hermit-rs
that referenced
this pull request
Jul 15, 2025
hermit-os/kernel#1825 makes virtio-net an optional feature. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Gelbpunkt
added a commit
to Gelbpunkt/hermit-rs
that referenced
this pull request
Jul 15, 2025
hermit-os/kernel#1825 makes virtio-net an optional feature. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.