Remove custom certificate handling #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certificate validation logic implemented in the Data SDK is a subject of transient errors, as it is implemented on top of deprecated APIs. Given that there's no handling of the custom certificates and logic corresponds to the default certificate handling in the iOS, custom implementation can be removed in the faviour of default handling. Relates-To: HERESDK-5806 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
diachenko-mischa
force-pushed
the
mdiachenko/HERESDK-5806-RemoveCertCode
branch
from
5b00732 to
52a0dbb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
- Coverage 80.30% 80.28% -0.01%
==========================================
Files 349 349
Lines 13952 13953 +1
Branches 1492 1493 +1
==========================================
- Hits 11203 11202 -1
- Misses 2148 2152 +4
+ Partials 601 599 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykolamalik
approved these changes
Sep 11, 2025
rustam-gamidov-here
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificate validation logic implemented in the
Data SDK is a subject of transient errors, as
it is implemented on top of deprecated APIs.
Given that there's no handling of the custom
certificates and logic corresponds to the
default certificate handling in the iOS, custom
implementation can be removed in the faviour
of default handling.
Relates-To: HERESDK-5806