Make boost::optional as default regardless of C++ version. #1631
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proper PR name will make it easier to read log in future |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
+ Coverage 80.30% 80.33% +0.03%
==========================================
Files 349 349
Lines 13951 13952 +1
Branches 1492 1492
==========================================
+ Hits 11202 11207 +5
+ Misses 2150 2146 -4
Partials 599 599 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit makes the boost::optional default even for C++17 builds. The std::optional usage shall be switched on explicitly using OLP_SDK_USE_STD_OPTIONAL=ON flag. Relates-To: NLAM-23 Signed-off-by: sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
f9719c0 to
11df58b
Compare
asopov-here
changed the title
mykolamalik
approved these changes
Aug 12, 2025
andrey-kashcheev
approved these changes
Aug 12, 2025
rustam-gamidov-here
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit makes the boost::optional default even for C++17 builds. The std::optional usage shall be switched on explicitly using OLP_SDK_USE_STD_OPTIONAL=ON flag.
Relates-To: NLAM-23