Skip to content

Decrease allocations in QuadTreeIndex #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

mykhailo-kuchma
Copy link
Collaborator

Added a fields parameter to GetIndexData method.
Change GetIndexData method to skip string fields which are not needed.

Relates-To: DATASDK-64

@mykhailo-kuchma mykhailo-kuchma changed the title Decrease allocations in QUadTreeIndex Decrease allocations in QuadTreeIndex Apr 7, 2025
Added a `fields` parameter to GetIndexData method.
Change GetIndexData method to skip string fields which are not needed.

Relates-To: DATASDK-64

Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 81.70732% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.25%. Comparing base (49ef5d4) to head (d95c97e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ataservice-read/src/repositories/QuadTreeIndex.cpp 85.96% 2 Missing and 6 partials ⚠️
olp-cpp-sdk-dataservice-read/src/BlobDataReader.h 76.92% 1 Missing and 2 partials ⚠️
...-read/src/repositories/PrefetchTilesRepository.cpp 25.00% 3 Missing ⚠️
...-dataservice-read/src/repositories/QuadTreeIndex.h 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
- Coverage   80.25%   80.25%   -0.00%     
==========================================
  Files         348      348              
  Lines       13867    13881      +14     
  Branches     1480     1483       +3     
==========================================
+ Hits        11128    11139      +11     
- Misses       2142     2145       +3     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mykhailo-kuchma mykhailo-kuchma merged commit ac33d9f into master Apr 7, 2025
24 checks passed
@mykhailo-kuchma mykhailo-kuchma deleted the task/DATASDK-64 branch April 7, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants