Skip to content

Force CMake 3.5 for Snappy #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Force CMake 3.5 for Snappy #1600

merged 1 commit into from
Apr 2, 2025

Conversation

andrey-kashcheev
Copy link
Collaborator

CMake 4.0 doesn't support cases when required version is too low

Relates-To: MINOR

CMake 4.0 doesn't support cases when required version is too low

Relates-To: MINOR

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
@andrey-kashcheev andrey-kashcheev changed the title Update Snappy Force CMake 3.5 for Snappy Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (6223287) to head (69523e5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   80.27%   80.22%   -0.05%     
==========================================
  Files         348      348              
  Lines       13866    13867       +1     
  Branches     1480     1480              
==========================================
- Hits        11130    11124       -6     
- Misses       2140     2144       +4     
- Partials      596      599       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrey-kashcheev andrey-kashcheev merged commit 235fd06 into master Apr 2, 2025
24 checks passed
@andrey-kashcheev andrey-kashcheev deleted the update-snappy branch April 2, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants