IOTSDK-24021: Fix parsing of server DateTime #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diachenko-mischa
force-pushed
the
mdiachenko/FixParsingOfServerDateTime
branch
from
ea7c688 to
57a10d9
Compare
diachenko-mischa
requested review from
mykolamalik,
mykhailo-kuchma and
andrey-kashcheev
diachenko-mischa
force-pushed
the
mdiachenko/FixParsingOfServerDateTime
branch
from
57a10d9 to
be42396
Compare
mykolamalik
requested changes
Apr 22, 2024
diachenko-mischa
force-pushed
the
mdiachenko/FixParsingOfServerDateTime
branch
from
11fbf3a to
d229e49
Compare
std::get_time does not claim support of time zones in the string parameter, and seems to be subject of locale set on the system. An example is a following result on linux: ParseTime(Thu, 1 Jan 1970 0:00:00 GMT)=-2209075200 ::strptime is also a subject to the time zones of locale, but it also claim support for parsing a time zone from the passed string. Thus, additional logic incorporated to offset parsed DataTime to the local timezone. Relates-To: IOTSDK-24021 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
diachenko-mischa
force-pushed
the
mdiachenko/FixParsingOfServerDateTime
branch
from
d229e49 to
ab589d4
Compare
Fixed |
mykolamalik
approved these changes
Apr 22, 2024
mykhailo-kuchma
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::get_time does not claim support of time zones in the string parameter, and seems to be subject of locale set on the system. An example is a following result on linux:
ParseTime(Thu, 1 Jan 1970 0:00:00 GMT)=-2209075200
::strptime is also a subject to the time zones of locale, but it also claim support for parsing a time zone from the passed string. Thus, additional logic incorporated to offset parsed DataTime to the local timezone.