- 
                Notifications
    
You must be signed in to change notification settings  - Fork 15
 
broken parmetis link fix #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           +1  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help.
| 
           I see that this is a known problem due to the Karypis group moving their website to Github The replacement URL should be https://karypis.github.io/glaros/files/sw/parmetis/parmetis-4.0.2.tar.gz rather than the CP2K website Thanks for this.  | 
    
          
 Updated the link. Thank you.  | 
    
| 
           Can you please rebase and squash the commits into 2 or 3? Thanks!  | 
    
          
 Yes. Done from my side. Thank you. Update:  | 
    
8b8c635    to
    ea25d01      
    Compare
  
    | 
           I have pushed the commit ff6f3ae, where you updated GH action version, in my fork.  | 
    
add hemelb python dependencies remove vmtk requirement, because this can be covered through hemelb-spec-2024-12-06.txt file update vagrantfile update gitignore update vmtk update gitignore
94612c4    to
    0015b67      
    Compare
  
    | 
           Hi - thanks for spotting this and making the change. There are a whole load of minor edits to things that I can't accept (e.g the reflowing of large bits of the docs). I have cherry picked to main the change at the crux of this PR. If you wish to do a documentation tidy that would be gratefully accepted but needs to not make large amounts on unneeded and undesired changes. Thanks  | 
    
          
 @rupertnash Thank you for your earlier feedback. I’ve submitted a new PR with only minimal and relevant documentation updates, available here: #824. It only changes to essential clarifications, structural fixes, and new machine-specific content. Please let me know if any revisions are needed. Thanks!  | 
    
Previous link of Parmetis 4.0.2 is invalid/broken. I have updated it with the latest working link of Parmetis v4.0.2.