Skip to content

Conversation

@lepotatoguy
Copy link

@lepotatoguy lepotatoguy commented Feb 7, 2025

Previous link of Parmetis 4.0.2 is invalid/broken. I have updated it with the latest working link of Parmetis v4.0.2.

@showrav-ansary
Copy link

+1

Copy link
Member

@rupertnash rupertnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help.

@rupertnash
Copy link
Member

I see that this is a known problem due to the Karypis group moving their website to Github
KarypisLab/ParMETIS#27

The replacement URL should be https://karypis.github.io/glaros/files/sw/parmetis/parmetis-4.0.2.tar.gz rather than the CP2K website

Thanks for this.

@lepotatoguy
Copy link
Author

I see that this is a known problem due to the Karypis group moving their website to Github KarypisLab/ParMETIS#27

The replacement URL should be https://karypis.github.io/glaros/files/sw/parmetis/parmetis-4.0.2.tar.gz rather than the CP2K website

Thanks for this.

Updated the link. Thank you.

@rupertnash
Copy link
Member

Can you please rebase and squash the commits into 2 or 3? Thanks!

@lepotatoguy
Copy link
Author

lepotatoguy commented Apr 29, 2025

Can you please rebase and squash the commits into 2 or 3? Thanks!

Yes. Done from my side. Thank you.

Update:
I noticed that the numpy version comment was still missing and the hemelb-spec-2024-12-06.txt file you requested to remove was still present.
I have corrected both issues — the comment has been added back and the file has been removed.
The commits have been updated accordingly. It should be ready for review now.

@lepotatoguy lepotatoguy force-pushed the main branch 3 times, most recently from 8b8c635 to ea25d01 Compare April 30, 2025 01:46
@lepotatoguy
Copy link
Author

I have pushed the commit ff6f3ae, where you updated GH action version, in my fork.

add hemelb python dependencies

remove vmtk requirement, because this can be covered through hemelb-spec-2024-12-06.txt file

update vagrantfile

update gitignore

update vmtk

update gitignore
@lepotatoguy lepotatoguy force-pushed the main branch 2 times, most recently from 94612c4 to 0015b67 Compare May 4, 2025 09:30
@rupertnash
Copy link
Member

Hi - thanks for spotting this and making the change. There are a whole load of minor edits to things that I can't accept (e.g the reflowing of large bits of the docs). I have cherry picked to main the change at the crux of this PR. If you wish to do a documentation tidy that would be gratefully accepted but needs to not make large amounts on unneeded and undesired changes. Thanks

@rupertnash rupertnash closed this May 14, 2025
@lepotatoguy
Copy link
Author

Hi - thanks for spotting this and making the change. There are a whole load of minor edits to things that I can't accept (e.g the reflowing of large bits of the docs). I have cherry picked to main the change at the crux of this PR. If you wish to do a documentation tidy that would be gratefully accepted but needs to not make large amounts on unneeded and undesired changes. Thanks

@rupertnash Thank you for your earlier feedback.

I’ve submitted a new PR with only minimal and relevant documentation updates, available here: #824. It only changes to essential clarifications, structural fixes, and new machine-specific content.

Please let me know if any revisions are needed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants