Octree-based geometry tool #782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupertnash
force-pushed
the
oct-rebase
branch
2 times, most recently
from
d39f330 to
2b5cc6d
Compare
|
Note issue regarding origin of OCT and GMY coordinates differing. Can this be made the same? Consider whether we should allow the OCT and GMY generators to coexist rather than replacing |
rupertnash
force-pushed
the
oct-rebase
branch
5 times, most recently
from
7638a8e to
914cdec
Compare
rupertnash
force-pushed
the
oct-rebase
branch
2 times, most recently
from
368b776 to
3bd280c
Compare
- Moved all code into namespace - Pulled common parts (ie. hemelb::util::Vector3D) into own extension - Made block size settable for GMY (to make interfaces more similar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the tree available may be useful for checkpoint/restart. As a first step, recommission the octree-based geometry tool with the OCT -> GMY -> HemeLB workflow
Need to get a test passing in CI