Compatibility with Contao 5 #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # composer.json
koertho
reviewed
Feb 16, 2024
dca/tl_content.php
Outdated
| return $bundles; | ||
| }; | ||
|
|
||
| if (!in_array('ce-access', $getActiveBundles())) |
There was a problem hiding this comment.
ce_access wurde in den Core Integriert, da lohnt sich eine Prüfung nicht mehr ;)
There was a problem hiding this comment.
Was ist mit dieser Prüfung? @koertho
if(in_array('GlobalContentelements',$this->Config->getActiveModules()))
dca/tl_content.php
Outdated
| $getActiveBundles = function () { | ||
| $bundles = array_keys(System::getContainer()->getParameter('kernel.bundles')); | ||
|
|
||
| $legacy = [ |
There was a problem hiding this comment.
Denke, dass wir das legacy mapping nicht mehr brauchen? 🤷♂️
|
Hallo, wird es subcolumns auch für C5 geben? Habt ihr schon eine Tendenz, wann die Erweiterung im CM verfügbar sein könnte? Viele Grüße und Danke! |
|
@lplusl Wir werden Subcolumn nicht für Contao 5 fit machen. Wir haben uns Intern für contao-bootstrap/grid entschieden und auch eine entsprechende Migration gebaut: https://github.com/heimrichhannot/contao-subcolumns2grid-migration-bundle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.