-
Couldn't load subscription status.
- Fork 5.5k
increase default password length validation to minimum 12 characters #5685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I like this change. It's simple and increases the security for default installations. I expect all developers to already use password managers that generate passwords that are mostly longer than 20chars. So this is only helping people to choose a more secure password not already using a password manager. We need to remember that there are a lot of people not using a password manager, which would really use 6 chars long passwords when possible. |
|
@gregmolnar @salzig Can I say that I agree with both of you on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a maintainer but want to show my support 😄
|
I just realized that this would be a breaking change, so I will rework it. Ideally when a password is updated the new length would be required, I will look into how to make that happen. |
|
And just like that he almost broke the entire rails based internet 😂😂😂 |
Wouldn't be the first time, nor the last time :) |
|
@gregmolnar i start to have the Impression that no one is merging anything here TBH |
|
I changed this to set the new minimum length for newly generated configs. Let's see it maintenance picks up and then I will work on rolling this out on password updates too. |
No description provided.