chore: setup ci #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3arthqu4ke
force-pushed
the
setup-ci
branch
3 times, most recently
from
7c57752 to
cf77a87
Compare
3arthqu4ke
force-pushed
the
setup-ci
branch
7 times, most recently
from
2b388a3 to
38cb24e
Compare
3arthqu4ke
commented
Dec 7, 2024
| uses: useblacksmith/cache@v5 | ||
| with: | ||
| path: build | ||
| key: build-${{ inputs.mc }}-${{ hashFiles('./*') }} |
There was a problem hiding this comment.
This is not great and should exclude files like release-please-config.json, README.MD and LICENSE, but besides those all other files affect ci, code or build system and changes should satisfy a rebuild of everything
3arthqu4ke
commented
Dec 7, 2024
| if "${{ steps.filter.outcome }}" == "success": | ||
| # TODO: if only README or LICENSE changed, no need to run all versions! | ||
| # dirs_to_filter = json.loads('${{ steps.filter.outputs.changes }}') | ||
| versions_to_run = ['all'] |
There was a problem hiding this comment.
See above, almost all files are ci, code or build system now and should cause everything to be rebuild
|
It would probably make it simpler to place all code in a subdirectory again? |
I would encourage this yes. |
ChipWolf
requested changes
Dec 9, 2024
ChipWolf
force-pushed
the
setup-ci
branch
4 times, most recently
from
a986ca4 to
4f53f57
Compare
ChipWolf
force-pushed
the
setup-ci
branch
7 times, most recently
from
a220151 to
58fb829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.