Skip to content

Use getentropy in splitmix_init on unix-like platforms #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jun 8, 2025

No description provided.

@phadej phadej force-pushed the getentropy branch 3 times, most recently from 3b92063 to 67099cf Compare June 9, 2025 16:14
@phadej phadej merged commit 9fcc47e into master Jun 9, 2025
22 checks passed
@phadej phadej deleted the getentropy branch June 9, 2025 17:14
@kazu-yamamoto
Copy link

If glibc 2.24 or earlier, which does not provide getentropy(), is installed in Linux, the build fails.

@phadej
Copy link
Collaborator Author

phadej commented Jun 10, 2025

According to the internet, glibc 2.24 was released 4 Aug 2016. That's roughly nine years ago. The oldest GHC the just released splitmix supports is GHC-8.6.5 released 23 April 2019. (GHC-8.6.1 is from september 2018).

TL;DR, if you run old glibc machine, don't upgrade splitmix. Upgrade your glibc first.

@kazu-yamamoto
Copy link

Make sense.
CentOS 7 does not allow any upgrades anymore.
This is good time to throw away it.
As workaround, I stay with the old splitmix for a while.

@amesgen amesgen mentioned this pull request Jun 10, 2025
@AshleyYakeley
Copy link

Does this close #93 as well?

@phadej
Copy link
Collaborator Author

phadej commented Jun 10, 2025

@AshleyYakeley I don't know.

@AshleyYakeley
Copy link

This PR is in splitmix-0.1.2, right? I'll try it out and let you know.

@phadej
Copy link
Collaborator Author

phadej commented Jun 10, 2025

This PR is in splitmix-0.1.2, right?

Yes.

@AshleyYakeley
Copy link

This doesn't fix #93 because the problem there is that GHCJS can't find splitmix_init.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants