Skip to content

Update Hackage root keys #11095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Hackage root keys #11095

wants to merge 3 commits into from

Conversation

jmct
Copy link
Member

@jmct jmct commented Jul 23, 2025

Hackage Security has one new key and one key needing removal. The new root.json should go live on hackage in the next week.

The new root.json is here: haskell-infra/hackage-root-keys#23 is you want to compare the key signatures.

See #9068 for a prior MR in this series.

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • [N/A] Manual QA notes have been included.
  • [N/A] Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

@geekosaur
Copy link
Collaborator

This sounds like it should be backported to 3.14 and may warrant a point release in short order. I wonder if we should arrange for a point release containing only the key change for 3.12 as well?

@jmct
Copy link
Member Author

jmct commented Jul 23, 2025

While Tikhon's key was added, it was not used to sign this year's root.json.

Does that affect what's necessary here?

@geekosaur
Copy link
Collaborator

When does this become relevant, then? I still suspect we need to update versions of cabal that are in use at that point. (Arguably 3.10.3 is also in use, or at least I still hear of people using it, but I'm not sure that's in a releaseable state.)

Do we also need to tell people how to update their cabal config files since they have Hackage root keys in them?

@geekosaur
Copy link
Collaborator

(I should go look at the other PR but I'm on a call now so it'll have to wait a bit.)

@jmct
Copy link
Member Author

jmct commented Jul 23, 2025

I did not think it needed any action from the users, the previous PRs don't seem to mention that.

@jmct
Copy link
Member Author

jmct commented Jul 23, 2025

David C. (my predecessor and last person to do this) wrote the following for the Pantry/Stack part of it when new keys were added:

The new root key is authorized by the existing keyholders, so existing clients should give them the proper authority. However, new clients should have the current set of keyholders in the bootstrap set, which makes the system more robust against people leaving the process.

Unless cabal is doing something very different, I think this holds? So it is worth backporting for robustness but is not super urgent?

@geekosaur
Copy link
Collaborator

Okay, that sounds like it should be enough then. I was worried that the new key would cause rejections by the hackage-security framework, but if it takes cross-signing into account then it sounds like things are fine.

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Jul 23, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants