Tests for query command outputs #37343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsa0x
added
the
no-changelog-needed
dsa0x
force-pushed
the
sams/query-output-testing
branch
from
e7fd3fb to
afb2730
Compare
dsa0x
force-pushed
the
sams/query-output-testing
branch
from
875323e to
d2b4619
Compare
Return warning to the CLI if the config has no query files.
dbanck
force-pushed
the
sams/query-output-testing
branch
from
d2b4619 to
7822e33
Compare
dbanck
reviewed
Jul 23, 2025
| t.Fatalf("bad: %d\n\n%s", code, output.Stderr()) | ||
|
|
||
| // Check that we have query output | ||
| if !strings.Contains(actual, ts.expectedOut) { |
There was a problem hiding this comment.
I expected this test to fail after merging the updates to the line-based output. However, it appears that this line is never executed. I think the if statements are mixed up here.
dbanck
reviewed
Jul 23, 2025
| output = done(t) | ||
| actual := output.All() | ||
| if len(ts.expectedErr) == 0 { | ||
| if code != 0 && len(ts.expectedErr) == 0 { |
There was a problem hiding this comment.
Suggested change
| if code != 0 && len(ts.expectedErr) == 0 { | |
| if code != 0 { |
We already checked this in the line above
dbanck
reviewed
Jul 23, 2025
| diags = diags.Append(tfdiags.Sourceless( | ||
| tfdiags.Error, | ||
| "No configuration files", | ||
| "Query Plan requires a query configuration to be present. Create a Terraform query configuration file (.tfquery.hcl file) and try again.", |
There was a problem hiding this comment.
Suggested change
| "Query Plan requires a query configuration to be present. Create a Terraform query configuration file (.tfquery.hcl file) and try again.", | |
| "Query requires a query configuration to be present. Create a Terraform query configuration file (.tfquery.hcl file) and try again.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some tests for query command outputs. Also, a warning is returned when the config does not have any list resources.
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry