Skip to content

HCP Waypoint agent actions support #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

HenryEstberg
Copy link
Contributor

@HenryEstberg HenryEstberg commented Jun 5, 2025

🛠️ Description

Added new supported action type to the hcp_waypoint_action resource and data source. In addition, added new hcp_waypoint_agent_group resource and data source.

As a note to reviewers, adding new test cases in the action resource and data source appears to have either caused a race condition, or made it far more likely. This appears to have been solved by making those tests in particular not parallelized like the rest of the Waypoint acceptance tests. I have not been able to reproduce the failure after making that change.

🏗️ Acceptance tests

Output from acceptance testing:

// This command runs all Waypoint acceptance tests, only relevant outputs included here
$ make testacc TESTARGS='-run=TestAccWaypoint'

--- PASS: TestAcc_Waypoint_Action_basic (9.56s)
--- PASS: TestAcc_Waypoint_Agent_Group_DataSource_basic (7.17s)
--- PASS: TestAcc_Waypoint_Action_DataSource_Agent (7.01s)
--- PASS: TestAcc_Waypoint_Agent_Group_basic (4.57s)
...

PCI review checklist

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've worked with GRC to document the impact of any changes to security controls.

    Examples of changes to controls include access controls, encryption, logging, etc.

  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.

    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@HenryEstberg HenryEstberg changed the title HCP Waypoint agent action type support HCP Waypoint agent actions support Jun 5, 2025
@HenryEstberg HenryEstberg marked this pull request as ready for review June 10, 2025 00:56
@HenryEstberg HenryEstberg requested review from a team as code owners June 10, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants