Skip to content

Add awscc_pcs_compute_node_group #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Conversation

wellsiau-aws
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Relates OR Closes #2157

Upstream schema refresh and rebuild with awscc_pcs_compute_node_group

@wellsiau-aws
Copy link
Collaborator Author

Simple test

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # awscc_pcs_compute_node_group.login will be created
  + resource "awscc_pcs_compute_node_group" "login" {
      + ami_id                   = "ami-0806233239aed8761"
      + arn                      = (known after apply)
      + cluster_id               = "pcs_xg3mmgdci7"
      + compute_node_group_id    = (known after apply)
      + custom_launch_template   = {
          + template_id = "lt-08f5c327aee3a02fd"
          + version     = "1"
        }
      + error_info               = (known after apply)
      + iam_instance_profile_arn = "arn:aws:iam::204034886740:instance-profile/AWSPCS-PCS-get-started-cfn-us-east-1"
      + id                       = (known after apply)
      + instance_configs         = [
          + {
              + instance_type = "c6i.xlarge"
            },
        ]
      + name                     = "logintest"
      + purchase_option          = (known after apply)
      + scaling_configuration    = {
          + max_instance_count = 1
          + min_instance_count = 1
        }
      + slurm_configuration      = (known after apply)
      + spot_options             = (known after apply)
      + status                   = (known after apply)
      + subnet_ids               = [
          + "subnet-0738f849d594c1822",
          + "subnet-01c96cf7e5dadd8d9",
        ]
      + tags                     = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.
awscc_pcs_compute_node_group.login: Creating...
awscc_pcs_compute_node_group.login: Still creating... [10s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [20s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [30s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [40s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [50s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [1m0s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [1m10s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [1m20s elapsed]
awscc_pcs_compute_node_group.login: Still creating... [1m30s elapsed]
awscc_pcs_compute_node_group.login: Creation complete after 1m36s [id=arn:aws:pcs:us-east-1:204034886740:cluster/pcs_xg3mmgdci7/computenodegroup/pcs_64c8i88pho]

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you include a changelog entry?

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b
Copy link
Member

jar-b commented Mar 17, 2025

Thanks for the contribution, @wellsiau-aws! 👍

@jar-b jar-b merged commit da6a544 into hashicorp:main Mar 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awscc_pcs_compute_node_group not available in Terraform registry
4 participants