Skip to content

provider: build with Go 1.23.5 #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

provider: build with Go 1.23.5 #2202

merged 1 commit into from
Feb 12, 2025

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Feb 12, 2025 •
edited
Loading

Build with the same Go version currently used in the standard AWS provider.

Closes #2174
Relates hashicorp/terraform-provider-aws#41124

% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_'
TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 20 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m

--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (2.18s)
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (30.34s)
--- PASS: TestAccAWSLogsLogGroup_basic (33.64s)
--- PASS: TestAccAWSLogsLogGroup_disappears (35.07s)
--- PASS: TestAccAWSLogsLogGroup_update (46.80s)
PASS
ok      github.com/hashicorp/terraform-provider-awscc/internal/aws/logs 47.874s

@jar-b jar-b requested a review from a team as a code owner February 12, 2025 16:13
@johnsonaj
Copy link
Contributor

I believe this changed needs to happen in the .go-version file as well

@jar-b
Copy link
Member Author

jar-b commented Feb 12, 2025

I believe this changed needs to happen in the .go-version file as well

Fixed.

johnsonaj
johnsonaj approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b merged commit 9e43807 into main Feb 12, 2025
14 checks passed
@jar-b jar-b deleted the go-1.23.5 branch February 12, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
prioritized
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build with Go 1.23.5
2 participants
@jar-b @johnsonaj