Align and standardize TFE HTTP/S container port inputs across runtimes #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces two new input variables for configuring the TFE application ports: TFE_HTTP_PORT and TFE_HTTPS_PORT. The default values are set to
8080
and8443
, respectively. This brings the AWS module in line with the TFE on Azure and GCP HVD modules, which already supported these inputs with the same defaults. It also ensures the TFE application container ports now default to the same values across Docker and Podman, just as they already do in the Azure and GCP modules.Previously, these container port values were hard-coded based on the value of the
container_runtime
input:TFE_HTTP_PORT
was8080
,TFE_HTTPS_PORT
was8443
(due to rootless restrictions)TFE_HTTP_PORT
was80
,TFE_HTTPS_PORT
was443
With this change:
container_runtime = "podman"
) are unaffected, as the new defaults match the previously hard-coded values.container_runtime = "docker"
) will see a change: the TFE container will now listen on8080
and8443
by default, instead of80
and443
. If needed, users can override the new default values by setting the new input variables explicitly.Note: this update does not alter any host ports, so no changes are required to security groups, firewall rules, or load balancer listeners. Only the container ports change for Docker-based installs.
Related issue
N/A
Type of change
How has this been tested?
Checklist
Additional notes
[Add any additional information or context about the PR here]