Skip to content

Align and standardize TFE HTTP/S container port inputs across runtimes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

alexbasista
Copy link
Contributor

@alexbasista alexbasista commented Jun 9, 2025

Description

This change introduces two new input variables for configuring the TFE application ports: TFE_HTTP_PORT and TFE_HTTPS_PORT. The default values are set to 8080 and 8443, respectively. This brings the AWS module in line with the TFE on Azure and GCP HVD modules, which already supported these inputs with the same defaults. It also ensures the TFE application container ports now default to the same values across Docker and Podman, just as they already do in the Azure and GCP modules.

Previously, these container port values were hard-coded based on the value of the container_runtime input:

  • podman- TFE_HTTP_PORT was 8080, TFE_HTTPS_PORT was 8443 (due to rootless restrictions)
  • docker- TFE_HTTP_PORT was 80, TFE_HTTPS_PORT was 443

With this change:

  • Podman users (container_runtime = "podman") are unaffected, as the new defaults match the previously hard-coded values.
  • Docker users (container_runtime = "docker") will see a change: the TFE container will now listen on 8080 and 8443 by default, instead of 80 and 443. If needed, users can override the new default values by setting the new input variables explicitly.

Note: this update does not alter any host ports, so no changes are required to security groups, firewall rules, or load balancer listeners. Only the container ports change for Docker-based installs.

Related issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How has this been tested?

  • Tested both net new Podman and Docker-based deployments successfully.
  • Tested transitioning/upgrading from an existing Docker-based deployment to one with this change successfully with no impact (change was transparent).

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional notes

[Add any additional information or context about the PR here]

@alexbasista alexbasista self-assigned this Jun 9, 2025
@alexbasista alexbasista requested a review from a team as a code owner June 9, 2025 19:43
Copy link
Contributor

@jkellner-hashi jkellner-hashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🔝

Copy link
Contributor

@ml4 ml4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top 🍌

@alexbasista alexbasista merged commit b1e8b6a into main Jun 10, 2025
5 checks passed
@alexbasista alexbasista deleted the chore/variableize-tfe-http-ports branch June 10, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants