Skip to content

Airgap improvement #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025
Merged

Airgap improvement #24

merged 6 commits into from
May 28, 2025

Conversation

alexbasista
Copy link
Contributor

Description

Adding functionality, most significantly to user_data and IAM, to enable pulling the TFE application container image from a custom registry location (including conditional logic to support Amazon Elastic Container Registry with instance profile credentials) in a scenario where the TFE environment has limited to no egress connectivity to the public internet. This previously was not supported, although the input variables existed with default values to the publicly hosted location (images.releases.hashicorp.com). So this would almost fall in between the categories of a bug fix and new feature.

Related issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How has this been tested?

  • Deployed TFE successfully using Docker as the container runtime
  • Deployed TFE successfully using Podman as the container runtime
  • Verified Terraform runs within a workspace executed successfully on both
  • Tested upgrading to a new TFE version on both

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional notes

N/A

@alexbasista alexbasista requested a review from a team as a code owner May 28, 2025 13:35
Copy link
Contributor

@jkellner-hashi jkellner-hashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition 👍

Copy link
Contributor

@abuxton abuxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbasista alexbasista self-assigned this May 28, 2025
@alexbasista alexbasista merged commit 5115e9e into main May 28, 2025
4 checks passed
@alexbasista alexbasista deleted the feat/airgap-updates branch May 28, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants