Skip to content

Feature/NLB-sticky-sessions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025

Conversation

GlennChia
Copy link
Contributor

Description

[Provide a brief description of the changes in this PR]

Enable NLB Sticky Sessions.

Reference

  • HashiCorp Terraform Enterprise documentation

    Depending on your infrastructure and Terraform Enterprise configuration, you may need to configure your application gateway or load balancer for sticky sessions. Sticky session refers to the practice of using a load balancer or gateway device with a specific setting enabled that ensures traffic is routed back to the original system that initiated a request. For example, an Active/Active deployment on Azure with SAML authentication requires sticky sessions to ensure the authentication with the SAML server is successful. The terminology for this varies across clouds. Refer to the documentation for your infrastructure.”

  • Terraform AWS Provider: aws_lb_target_group

    • NLB Target Group type only supports source_ip as of today

Related issue

[Link to the related issue (if applicable)]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How has this been tested?

Deploy NLB Target Group with this block that does an in-place update, verify in console that sticky sessions is on.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional notes

[Add any additional information or context about the PR here]

@GlennChia GlennChia requested a review from a team as a code owner May 8, 2025 08:06
@GlennChia GlennChia force-pushed the feature/nlb-sticky-sessions branch from 18ff4b6 to 128db69 Compare May 8, 2025 08:15
Copy link
Contributor

@alexbasista alexbasista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeffmccollum jeffmccollum requested a review from a team May 9, 2025 19:07
@tristanmorgan tristanmorgan merged commit 307c0e7 into hashicorp:main May 11, 2025
4 checks passed
@GlennChia GlennChia deleted the feature/nlb-sticky-sessions branch May 13, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants