Skip to content

Fix disk grant access #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tianyiliuMSFT
Copy link

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

  1. Access URI of the disk should be returned from GrantAccessThenPoll, so the return value of this function is changed.
  2. AccessUri in GrantAccessOperationResponse doesn't match the actual one, which leads to unmarshal failure. Added and changed the fields of the struct.

This is a (please select all that apply):

  • Bug Fix
  • New Feature
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Jul 4, 2025
Copy link

hashicorp-cla-app bot commented Jul 4, 2025

CLA assistant check
All committers have signed the CLA.

@jackofallops
Copy link
Member

Hi @tianyiliuMSFT - unfortunately these files are generated and this change will be overwritten. The LRO should not return the URI of the created resource afaik, and a subsequent get on the ID can be used to retrieve the necessary data.

Since this PR would simply be overwritten by the next ingestion of the API specs, I'm going to have to close it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants