Skip to content

Fix IPv6 address handling in LAN <-> WAN join flooder #22226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix IPv6 address handling in LAN <-> WAN join flooder #22226

wants to merge 5 commits into from

Conversation

tkren
Copy link

@tkren tkren commented Mar 14, 2025

When advertise_addr is an IPv6 address, Consul WAN federation breaks and we get a constant stream of warnings:

[WARN]  agent.server.memberlist.wan: memberlist: Failed to resolve
i-02a3c94b46768b01f.aws-eu-west-1/2a05:d018:18a3:f202:64d9:1621:ab22:df45:8302:
lookup 2a05:d018:18a3:f202:64d9:1621:ab22:df45:8302: no such host

The LAN <-> WAN join flooder creates IPv6 addresses without square brackets with fmt.Sprintf("%s:%d", addr, s.WanJoinPort), which confuses net.SplitHostPort in memberlist.resolveAddr.

Fixes #22225

@tkren
Fix IPv6 address handling in LAN <-> WAN join flooder
8fa216a 
When `advertise_addr` is an IPv6 address, Consul WAN federation breaks
and we get a constant stream of warnings:
```
[WARN]  agent.server.memberlist.wan: memberlist: Failed to resolve
i-02a3c94b46768b01f.aws-eu-west-1/2a05:d018:18a3:f202:64d9:1621:ab22:df45:8302:
lookup 2a05:d018:18a3:f202:64d9:1621:ab22:df45:8302: no such host
```

The LAN <-> WAN join flooder creates IPv6 addresses without square
brackets with `fmt.Sprintf("%s:%d", addr, s.WanJoinPort)`, which
confuses `net.SplitHostPort` in `memberlist.resolveAddr`.

Fixes hashicorp#22225
@tkren tkren requested a review from a team as a code owner March 14, 2025 23:34
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Mar 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cfunkhouser
Copy link

It would be great to get this fix in, or at least get some feedback on the state of #22225. Can anyone comment on how fixes are being prioritized?

sreeram77
sreeram77 requested changes Apr 29, 2025
View reviewed changes
Copy link
Member

@sreeram77 sreeram77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog as per this doc

@srahul3 srahul3 added the backport/1.21 Changes are backported to 1.21 label Apr 29, 2025
@tkren tkren requested a review from sreeram77 April 29, 2025 21:42
@srahul3 srahul3 added the backport/ent/1.21 changes are backported to 1.21 ent label May 23, 2025
@tanmay17061
Copy link

Hi @tkren,
Thanks for your contribution!

We'll also need you to accept the CLA by clicking on the license/cla under 1 pending check to merge your PR.

@tkren
Copy link
Author

tkren commented May 26, 2025 •
edited
Loading

Hi @tkren, Thanks for your contribution!

We'll also need you to accept the CLA by clicking on the license/cla under 1 pending check to merge your PR.

Hi @tanmay17061, sorry for my ignorance, but how do I do that? I did it before here: #22226 (comment), see https://cla.hashicorp.com/hashicorp/consul?pullRequest=22226

All I can see is this:

image

@tanmay17061
Copy link

Sorry, I missed that you've already accepted the CLA.
Let me get this checked, this check should ideally pass now AFAIK.

@tkren
Copy link
Author

tkren commented May 27, 2025

@tanmay17061 I found a way: https://cla.hashicorp.com/check/hashicorp/consul?pullRequest=22226 will perform a re-check for this PR; license/cla is ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreeram77 sreeram77 Awaiting requested review from sreeram77

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
backport/ent/1.21 changes are backported to 1.21 ent backport/1.21 Changes are backported to 1.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPv6 address handling broken in LAN <-> WAN join flooder
5 participants
@tkren @cfunkhouser @tanmay17061 @sreeram77 @srahul3