Skip to content

FFM-11654 Sort serving rules in cache code #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

FFM-11654 Sort serving rules in cache code #192

merged 1 commit into from
Jun 28, 2024

Conversation

erdirowlands
Copy link
Contributor

What

  • Move the group AND/OR rules outside of the critical evaluation path into the point we save them to the cache.

Why

Avoid the cost of sorting multiple times during evaluations when it is unnecessary, which can add evaluation latency.

Testing

TestGrid - both old style and new style scenarios pass.

Copy link
Contributor

@akiraqb akiraqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted to Erdi, looks apart form the apikey

@erdirowlands
Copy link
Contributor Author

Chatted to Erdi, looks apart form the apikey

thanks - removed and history wiped.

@erdirowlands erdirowlands merged commit 441577c into main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants