feat: Add PDF export functionality to main API (resolves #53)feat: Add PDF export functionality to main API (resolves #53)Update _… #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #53 by integrating the existing PDF export functionality into the main Harmony API. The PDF export functionality was already fully implemented and comprehensively tested, but not exposed through the main API. This change completes the integration, allowing users to create human-readable PDF reports with statistics, graphics, and professional formatting.
Changes:
generate_pdf_report,generate_harmony_pdf_report, andgenerate_basic_harmony_reportfromservices.export_pdf_reportFixes #53
Type of change
Testing
The PDF export functionality is already comprehensively tested with extensive unit tests in
tests/test_export_pdf_report.py. These tests cover:All existing tests continue to pass. The change only adds imports to expose existing functionality.
Test Configuration
Checklist
Additional Context
This change enables users to call PDF export functions directly after importing harmony:
The implementation includes graceful error handling, so users who don't have PDF dependencies installed will receive clear installation instructions.…init_.py
This commit addresses issue #53 by integrating the existing PDF export functionality into the main Harmony API.
Changes:
The PDF export functionality was already fully implemented and tested, but not exposed through the main API. This change completes the integration, allowing users to create human-readable PDF reports with statistics, graphics, and professional formatting as requested in issue #53.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant context. List any dependencies that are required for this change. Ideally we avoid introducing any new third party dependencies in
requirements.txtandpyproject.tomlunless absolutely necessary, because this makes the project more susceptible to breaking whenever a third party library is updated.Fixes # (issue)
Type of change
Please delete options that are not relevant.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Since the Harmony Python package is used by the Harmony API (which is itself used by the R library and the web app), we need to avoid making any changes that break the Harmony API. Please also run the Harmony API unit tests and check that the API still runs with your changes to the Python package: https://github.com/harmonydata/harmonyapi
Test Configuration
Checklist
requirements.txt,pyproject.tomland also in therequirements.txtin the API repoOptionally: feel free to paste your Discord username in this format:
discordapp.com/users/yourIDin your pull request description, then we can know to tag you in the Harmony Discord server when we announce the PR.