Skip to content

Keep search field visible in long lists #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Anujjoshi3105
Copy link
Contributor

Fixes #147
The search field remains visible at the top of the viewport when scrolling.
image

Copy link
Collaborator

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! However what I had asked is exactly what's needed, not position: absolute

.header {
    position: sticky;
    top: 10px;
    background: gray;
    outline: solid 10px gray;
	z-index: 100
}

Just the values need to be adjusted, for example to use var() for the margin and the color.

scroll

@Anujjoshi3105 Anujjoshi3105 requested a review from fregante August 13, 2024 18:48
@fregante fregante changed the title feat(search): make search field sticky on scroll Keep search field visible in long lists Aug 13, 2024
@Anujjoshi3105
Copy link
Contributor Author

Ligth and dark mode working
light

@fregante fregante merged commit 89f2ea2 into hankxdev:main Aug 14, 2024
3 checks passed
@fregante
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep search field visible
2 participants