internal/vibration: bug fix: vibration doesn't work when touch feedback was muted #3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck was muted Calling `vibrate` without specifying the usage didn't work when the global setting 'touch feedback' is 0. As the application's vibration has nothing to do with touch feedbacks, this is an unexpected behavior. Specify AudioAttributes or VibrationAttributes expcliitly. Closes #3300
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where vibration functionality didn't work when the Android system's global "touch feedback" setting was disabled. The fix ensures that application vibrations work independently of this system setting by explicitly specifying VibrationAttributes or AudioAttributes with appropriate usage values.
- Adds explicit VibrationAttributes (API 33+) and AudioAttributes (API 26-32) with media/game usage to bypass touch feedback restrictions
- Updates vibrator service acquisition to use VibratorManager for API 31+ for better compatibility
- Improves resource management with proper cleanup of JNI local references
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
#3300
What type of issue is this addressing?
bug
What this PR does | solves
Calling
vibratewithout specifying the usage didn't work when the global setting 'touch feedback' is 0. As the application's vibration has nothing to do with touch feedbacks, this is an unexpected behavior.Specify AudioAttributes or VibrationAttributes expcliitly.