Skip to content

Add possibility to Self update #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 18, 2025
Merged

Add possibility to Self update #113

merged 7 commits into from
Jan 18, 2025

Conversation

hacknus
Copy link
Owner

@hacknus hacknus commented Jan 17, 2025

The user can check for updates and the application will automatically download the latest release from github.

@hacknus hacknus merged commit 8cf8d07 into main Jan 18, 2025
2 checks passed
@hacknus hacknus deleted the self-update branch January 18, 2025 16:17
@zimward
Copy link
Contributor

zimward commented Jan 21, 2025

I would like to have this under feature flag, so it can be disabled if packaged to prevent nagging the user with an update that might not even work as they should rely on the package manager in that case.

@hacknus
Copy link
Owner Author

hacknus commented Jan 21, 2025

I would like to have this under feature flag, so it can be disabled if packaged to prevent nagging the user with an update that might not even work as they should rely on the package manager in that case.

good point! I'll put it in as a feature that is enabled by default for the automatically built binary releases.

@hacknus
Copy link
Owner Author

hacknus commented Jan 22, 2025

@zimward should I make the self_update feature the default or should we just enable it for building binaries?
EDIT it is now implemented as the default feature, but I can change it easily if you want. I don't really have an opinion on it.

@zimward
Copy link
Contributor

zimward commented Jan 22, 2025

I think having it as a non-default makes more sense as that would also make packaging easier as the maintainers don't need to look into build-flags. Only features that make sense for packaged builds should be default IMHO, as this is the default method of distribution outside of Windows and maybe MacOS (idk). Everyone who isn't using a package manager is probably using the CI binaries.

@hacknus
Copy link
Owner Author

hacknus commented Jan 22, 2025

thanks! done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants