Skip to content

fix: Failing h2o_wave installation when building the tour image #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: Failing h2o_wave installation when building the tour image #2289

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4e6244b
Fixed image bulding problem #2288
sulhicader Mar 14, 2024
5040694
Removed importing urllib3
sulhicader Mar 14, 2024
b19ad17
Added build-apps step
sulhicader Mar 14, 2024
e41be37
Rerun the github action
sulhicader Mar 14, 2024
a745830
Fixed the problem when bulding the tour image #2288
sulhicader Mar 14, 2024
055ca45
Triggering the flow
sulhicader Mar 21, 2024
a1a0cbb
Merge remote-tracking branch 'origin/main' into fix/issue-2288
sulhicader Mar 21, 2024
81d5de4
Removed importing urllib3
sulhicader Mar 21, 2024
be705e1
Changed the Path
sulhicader Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/release-wave.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@ jobs:
working-directory: ./py/tmp/tour/
run: chmod +x .bin/h2o

- name: Copy H2O Wave wheel
run: |
cp py/h2o_wave/dist/h2o_wave-${{ env.VERSION }}-py3-none-manylinux1_x86_64.whl ./py/tmp/tour/

- name: Edit Requirements file
working-directory: ./py/apps/tour/
run: sed -i -r -e "s/h2o_wave==\{\{VERSION\}\}/h2o_wave-${{ env.VERSION }}-py3-none-manylinux1_x86_64.whl/g" requirements.txt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be moved into wave-bundle actions instead? Also please add a comment explaining why it's needed.

- name: Make air-gapped bundle
working-directory: ./py/tmp/tour/
run: |
Expand Down