Skip to content

set option if want order column has checkbox #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joefreire
Copy link

i has a problem to order a column with this library, i fix this with this file

i has a problem to order a column with this library, i fix this with this file
@mpryvkin
Copy link
Member

mpryvkin commented Jun 8, 2018

Thanks for the PR, that's definitely helpful.

@mpryvkin
Copy link
Member

mpryvkin commented Jun 8, 2018

This needs more work than I initially thought. The problem is that the fix you're suggesting will make checkbox column orderable (because default value is true, see columns.orderable) unless disabled by orderable: false option. That is undesirable.

I need to find a way to detect whether orderable is specifically set in column options, or use false as default value.

@mpryvkin mpryvkin force-pushed the master branch 2 times, most recently from 301d948 to 9e47828 Compare May 8, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants