Skip to content

Fix #145 to datatable v2.0.3 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

alexsilva
Copy link
Contributor

I was already using the lib in version 1.x of the datatable, but when migrating to version 2.x, I got the failure described in issue #145 I made the corrections based on version 2.0.3 of the datatable (the internal apis are private were copied to source).

@DPComp
Copy link

DPComp commented Apr 14, 2024

how can I download your corrections?

@alexsilva
Copy link
Contributor Author

how can I download your corrections?

I generated a "compiled" version v1.3.0 with the Source

@DPComp
Copy link

DPComp commented Apr 17, 2024

how can I download your corrections?

I generated a "compiled" version v1.3.0 with the Source

Alex, I updated the js files + datatables 2.0.3
It stoped the failure, but it also stoped working... it's not showing the checkboxes anymore

example

columnDefs: [{
targets: 0,
orderable: false,
checkboxes: { selectRow: true },
},

this used to show a column with checkbox in the 1st row, and in the datatables 2.0.3 + your correction v1.3.0, it's not

@alexsilva
Copy link
Contributor Author

alexsilva commented Apr 17, 2024

@DPComp

how can I download your corrections?

I generated a "compiled" version v1.3.0 with the Source

Alex, I updated the js files + datatables 2.0.3 It stoped the failure, but it also stoped working... it's not showing the checkboxes anymore

example

columnDefs: [{ targets: 0, orderable: false, checkboxes: { selectRow: true }, },

this used to show a column with checkbox in the 1st row, and in the datatables 2.0.3 + your correction v1.3.0, it's not

I updated the source with a fix for this described problem.

I kept the version but generated a new min code.

mpryvkin added a commit that referenced this pull request Aug 2, 2024
Inspired by #147 by @alexsilva

Co-authored-by: alexsilva <geniofuturo@gmail.com>
@mpryvkin mpryvkin mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants