Skip to content

log audit #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2024
Merged

log audit #918

merged 5 commits into from
Jul 17, 2024

Conversation

dtam
Copy link
Contributor

@dtam dtam commented Jul 12, 2024

audited logging to only use logger v print and updated log levels and messages to be consistent

@dtam dtam changed the title inital audit updates log audit Jul 15, 2024
@dtam dtam marked this pull request as ready for review July 15, 2024 19:23
@dtam dtam requested a review from CalebCourier July 15, 2024 19:23
Copy link
Collaborator

@CalebCourier CalebCourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last update, we were using logging.warn in a few places instead of logging.warning. Let's make sure we're always using the latter.

@dtam dtam requested a review from CalebCourier July 16, 2024 22:25
@zsimjee zsimjee merged commit 5540b30 into 0.5.0-dev Jul 17, 2024
12 checks passed
@zsimjee zsimjee deleted the dtam/log_audit branch July 17, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants