Skip to content

update lxml #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update lxml #1279

wants to merge 1 commit into from

Conversation

evanvolgas
Copy link

@evanvolgas evanvolgas commented Jun 18, 2025

This updates lxml to a version that is compatible with PyDanticAI's DuckDuckGo search tool

https://ai.pydantic.dev/common-tools/

@evanvolgas
Copy link
Author

More generally speaking, would y'all be open to a PR that updates all of the packages that are old? This is the second one I've run into that was out of date #1274

@CalebCourier
Copy link
Collaborator

More generally speaking, would y'all be open to a PR that updates all of the packages that are old? This is the second one I've run into that was out of date #1274

Absolutely open to contributions. One sticking point is we need to maintain backwards compatibility where we can, so if a version is being updated, we prefer to widen the range to allow for either the current or newer versions to be installed.

@evanvolgas
Copy link
Author

What is the best way to test this on my end? I tried https://github.com/guardrails-ai/guardrails/blob/main/CONTRIBUTING.md and it's failing on the main branch, without my changes

@CalebCourier
Copy link
Collaborator

I see what you mean about the instructions in the contributing doc. Try running make full instead of make dev for installing dependencies then the tests should pass.

@evanvolgas
Copy link
Author

It works with make full

I see what you mean about the instructions in the contributing doc. Try running make full instead of make dev for installing dependencies then the tests should pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants